linux-kernel - Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200617213438.GF3675@piout.net>
Date:   Wed, 17 Jun 2020 23:34:38 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        nicolas.ferre@...rochip.com, ludovic.desroches@...rochip.com,
        claudiu.beznea@...rochip.com
Subject: Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic
 node"

Hi,

The correct subject line prefix is "ARM: dts: at91:"

On 15/06/2020 12:55:25+0300, Codrin Ciubotariu wrote:
> There are no PDM microphones on SAMA5D2 Xplained, to exercize the
> PDMIC.
> 
> This reverts commit ca6349a8c51f2e3d6f2acdb36431e7d7328261f7.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ----------------
>  1 file changed, 16 deletions(-)
> 

This patch doesn't apply and I think you'll have to motivate the removal
a bit more because this seems like a change of policy to me.

> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 54d96649da77..c0a255bda477 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -109,16 +109,6 @@ timer1: timer@1 {
>  				};
>  			};
>  
> -			pdmic@...18000 {
> -				pinctrl-names = "default";
> -				pinctrl-0 = <&pinctrl_pdmic_default>;
> -				atmel,model = "PDMIC @ sama5d2_xplained";
> -				atmel,mic-min-freq = <1000000>;
> -				atmel,mic-max-freq = <3246000>;
> -				atmel,mic-offset = <0x0>;
> -				status = "okay";
> -			};
> -
>  			uart1: serial@...20000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_uart1_default>;
> @@ -533,12 +523,6 @@ pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					bias-disable;
>  				};
>  
> -				pinctrl_pdmic_default: pdmic_default {
> -					pinmux = <PIN_PB26__PDMIC_DAT>,
> -						<PIN_PB27__PDMIC_CLK>;
> -					bias-disable;
> -				};
> -
>  				pinctrl_sdmmc0_default: sdmmc0_default {
>  					cmd_data {
>  						pinmux = <PIN_PA1__SDMMC0_CMD>,
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com