linux-kernel - Re: [PATCH] liquidio: Replace vmalloc_node + memset with vzalloc_node and use array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200617.150430.707659814683399868.davem@davemloft.net>
Date:   Wed, 17 Jun 2020 15:04:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavoars@...nel.org
Cc:     dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, gustavo@...eddedor.com
Subject: Re: [PATCH] liquidio: Replace vmalloc_node + memset with
 vzalloc_node and use array_size

From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Date: Mon, 15 Jun 2020 16:18:55 -0500

> Use vzalloc/vzalloc_node instead of the vmalloc/vzalloc_node and memset.
> 
> Also, notice that vzalloc_node() function has no 2-factor argument form
> to calculate the size for the allocation, so multiplication factors need
> to be wrapped in array_size().
> 
> This issue was found with the help of Coccinelle and, audited and fixed
> manually.
> 
> Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Applied to net-next, thanks.