linux-kernel - Re: [PATCH v8 3/9] firmware: arm_scmi: Add notification dispatch and delivery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jun 2020 00:31:05 +0100
From:   Cristian Marussi <cristian.marussi@....com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        lukasz.luba@....com, james.quinlan@...adcom.com,
        Jonathan.Cameron@...wei.com, dave.martin@....com,
        cristian.marussi@....com
Subject: Re: [PATCH v8 3/9] firmware: arm_scmi: Add notification dispatch and
 delivery

On Mon, Jun 08, 2020 at 06:03:46PM +0100, Sudeep Holla wrote:
> On Wed, May 20, 2020 at 09:11:12AM +0100, Cristian Marussi wrote:
> > Add core SCMI Notifications dispatch and delivery support logic which is
> > able, at first, to dispatch well-known received events from the RX ISR to
> > the dedicated deferred worker, and then, from there, to final deliver the
> > events to the registered users' callbacks.
> > 
> > Dispatch and delivery is just added here, still not enabled.
> > 
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> > Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> > ---
> >  drivers/firmware/arm_scmi/notify.c | 354 ++++++++++++++++++++++++++++-
> >  drivers/firmware/arm_scmi/notify.h |  10 +
> >  2 files changed, 362 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c
> > index 7cf61dbe2a8e..d582f71fde5b 100644
> > --- a/drivers/firmware/arm_scmi/notify.c
> > +++ b/drivers/firmware/arm_scmi/notify.c
> 
> [...]
> 
> > @@ -1085,6 +1422,12 @@ int scmi_notification_init(struct scmi_handle *handle)
> >  	ni->gid = gid;
> >  	ni->handle = handle;
> >  
> > +	ni->notify_wq = alloc_workqueue("scmi_notify",
> > +					WQ_UNBOUND | WQ_FREEZABLE | WQ_SYSFS,
> > +					0);
> 
> What's the use of WQ_SYSFS for SCMI notifications ? Do we need it ?
> 

Lukasz asked for it, when we were talking about workqueues' priorities configurability.
(not implemented in this series)

Thanks

Cristian
> -- 
> Regards,
> Sudeep