linux-kernel - Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jun 2020 20:40:28 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jacky Hu <hengqing.hu@...il.com>
Cc:     linux-hwmon@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, tony.luck@...el.com, x86@...nel.org,
        yazen.ghannam@....com, bp@...en8.de, clemens@...isch.de
Subject: Re: [PATCH] hwmon: (k10temp) Add AMD family 17h model 60h probe

On Wed, Jun 17, 2020 at 09:32:55AM +0800, Jacky Hu wrote:
> With this patch applied, output from 4800H (idle) looks as follows:
> 
> k10temp-pci-00c3
> Adapter: PCI adapter
> Vcore:         1.55 V
> Vsoc:          1.55 V
> Tctl:         +49.6°C
> Tdie:         +49.6°C
> Icore:         0.00 A
> Isoc:          0.00 A
> 
> Signed-off-by: Jacky Hu <hengqing.hu@...il.com>
> ---
>  drivers/hwmon/k10temp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 8f12995ec133..287e9cf2aab9 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -583,6 +583,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  			k10temp_get_ccd_support(pdev, data, 4);
>  			break;
>  		case 0x31:	/* Zen2 Threadripper */
> +		case 0x60:	/* Zen2 APU */

Unfortunately it is not that simple. Output above and the little data I have
available suggests that current and voltage measurements are different on the
APU. That means that show_current must remain false.
This will require a separate case statement which doesn't set any flags.

Guenter

>  		case 0x71:	/* Zen2 */
>  			data->show_current = !is_threadripper() && !is_epyc();
>  			data->cfactor[0] = CFACTOR_ICORE;
> -- 
> 2.27.0
>