[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f7997a48-eaec-839e-e0cd-cde718bd2e72@gmail.com>
Date: Wed, 17 Jun 2020 07:52:17 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Sowjanya Komatineni <skomatineni@...dia.com>,
thierry.reding@...il.com, jonathanh@...dia.com, frankc@...dia.com,
hverkuil@...all.nl, sakari.ailus@....fi, robh+dt@...nel.org,
helen.koike@...labora.com
Cc: sboyd@...nel.org, gregkh@...uxfoundation.org,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-i2c@...r.kernel.org
Subject: Re: [RFC PATCH v2 04/18] i2c: tegra: Fix the error path in
tegra_i2c_runtime_resume
17.06.2020 04:41, Sowjanya Komatineni пишет:
> tegra_i2c_runtime_resume does not disable prior enabled clocks
> properly.
>
> This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 3be1018..1b459ca 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -668,7 +668,7 @@ static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev)
> ret = clk_enable(i2c_dev->slow_clk);
> if (ret < 0) {
> dev_err(dev, "failed to enable slow clock: %d\n", ret);
> - return ret;
> + goto disable_fast_clk;
> }
> }
>
> @@ -676,11 +676,16 @@ static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev)
> if (ret < 0) {
> dev_err(i2c_dev->dev,
> "Enabling div clk failed, err %d\n", ret);
> - clk_disable(i2c_dev->fast_clk);
> - return ret;
> + goto disable_slow_clk;
> }
>
> return 0;
> +
> +disable_slow_clk:
> + clk_disable(i2c_dev->slow_clk);
> +disable_fast_clk:
> + clk_disable(i2c_dev->fast_clk);
> + return ret;
> }
>
> static int __maybe_unused tegra_i2c_runtime_suspend(struct device *dev)
>
This looks good to me. Could you please add an additional patch to
remove all the other conditions of the clk enable/disable? The current
code was already inconsistent because in most cases there are
conditions, but not in all cases.
Powered by blists - more mailing lists