linux-kernel - Re: [v3 PATCH 1/2] lockdep: Split header file into lockdep and lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jun 2020 10:24:59 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [v3 PATCH 1/2] lockdep: Split header file into lockdep and
 lockdep_types

On Wed, Jun 17, 2020 at 05:17:19PM +1000, Herbert Xu wrote:
> There is a header file inclusion loop between asm-generic/bug.h
> and linux/kernel.h.  This causes potential compile failurs depending
> on the which file is included first.  One way of breaking this loop
> is to stop spinlock_types.h from including lockdep.h.  This patch
> splits lockdep.h into two files for this purpose.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Acked-by: Petr Mladek <pmladek@...e.com>
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Looks good.

Petr, how about I stick this in tip/locking/header for us both to share?