linux-kernel - Re: [PATCH v2 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr1ueyscr.wl-tiwai@suse.de>
Date:   Wed, 17 Jun 2020 11:05:56 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        Hui Wang <hui.wang@...onical.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Wenwen Wang <wenwen@...uga.edu>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Kailang Yang <kailang@...ltek.com>,
        Jian-Hong Pan <jian-hong@...lessm.com>,
        Tomas Espeleta <tomas.espeleta@...il.com>,
        Thomas Hebb <tommyhebb@...il.com>,
        alsa-devel@...a-project.org (moderated list:SOUND),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH v2 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support

On Wed, 17 Jun 2020 06:58:24 +0200,
Kai-Heng Feng wrote:
> 
> Currently, HDA codec LED class can only used by by GPIO controlled LED.

A typo and missing verb :)

> However, there are some new systems that control LED via COEF instead of
> GPIO.
> 
> In order to support those systems, create a new helper that can be
> facilitated by both COEF controlled and GPIO controlled LED, and use
> generic call_micmute_led_update() to control both case.

An exported symbol should have the proper prefix (snd_hda_gen_xxx).


thanks,

Takashi