[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGOxZ51tpiBiTgns9q7X4w2rzvhc0U81s8st+f9PXDdmytJhAQ@mail.gmail.com>
Date: Wed, 17 Jun 2020 15:23:16 +0530
From: Alim Akhtar <alim.akhtar@...il.com>
To: Bean Huo <huobean@...il.com>
Cc: Avri Altman <Avri.Altman@....com>,
"daejun7.park@...sung.com" <daejun7.park@...sung.com>,
ALIM AKHTAR <alim.akhtar@...sung.com>,
"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
"asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
"beanhuo@...ron.com" <beanhuo@...ron.com>,
"stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
"cang@...eaurora.org" <cang@...eaurora.org>,
"bvanassche@....org" <bvanassche@....org>,
"tomas.winkler@...el.com" <tomas.winkler@...el.com>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Sang-yoon Oh <sangyoon.oh@...sung.com>,
Sung-Jun Park <sungjun07.park@...sung.com>,
yongmyung lee <ymhungry.lee@...sung.com>,
Jinyoung CHOI <j-young.choi@...sung.com>,
Adel Choi <adel.choi@...sung.com>,
BoRam Shin <boram.shin@...sung.com>
Subject: Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer
Hi Bean,
On Wed, Jun 17, 2020 at 3:12 PM Bean Huo <huobean@...il.com> wrote:
>
> > > HPB1.0 isn't part of ufs3.1, but published only later.
> > > Allowing earlier versions will required to quirk the descriptor
> > > sizes.
> > > I see Bean's point here, but I vote for adding it in a single
> > > quirk, when the time comes.
> > >
> >
> > I second Avri here, older devices need a quirk to handle, let do that
> > as a separate patch.
> > > Thanks,
> > > Avri
> >
> >
>
> what is useful point of adding a quirk for this?
>
> From the customer side piont, they just get our FW image, and then do
> FFU. If adding a quirk here, that means they also need to change UFS
> driver. Also, you expand the qurik structure.
>
>
> from cambridge dictionary:
> Qurik:
> an unusual habit or part of someone's personality, or something
> that
> is strange and unexpected.
>
> HPB feature is unexpected??
>
>
> please tell me the useful point of adding a Quirk.
>
The point is not about adding a quirk per say, it's about doing that
as a separate patch so that we know which device/ features are added
and why it is added. Please understand there is no denial about your
proposal or thought.
Thanks!!
> Bean
> >
>
--
Regards,
Alim
Powered by blists - more mailing lists