[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <babff895a0b5e2cd63082bd38f087bd1bc345671.camel@pengutronix.de>
Date: Wed, 17 Jun 2020 11:55:23 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
f.fainelli@...il.com, gregkh@...uxfoundation.org, wahrenst@....net,
linux-kernel@...r.kernel.org, Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list@...adcom.com,
Eric Anholt <eric@...olt.net>
Cc: linux-usb@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, tim.gover@...pberrypi.org,
linux-pci@...r.kernel.org, helgaas@...nel.org,
andy.shevchenko@...il.com, mathias.nyman@...ux.intel.com,
lorenzo.pieralisi@....com, Rob Herring <robh+dt@...nel.org>,
devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/9] dt-bindings: reset: Add a binding for the RPi
Firmware reset controller
Hi Nicolas,
On Fri, 2020-06-12 at 19:13 +0200, Nicolas Saenz Julienne wrote:
> The firmware running on the RPi VideoCore can be used to reset and
> initialize HW controlled by the firmware.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>
> ---
> Changes since v2:
> - Add include file for reset IDs
>
> Changes since v1:
> - Correct cells binding as per Florian's comment
> - Change compatible string to be more generic
>
> .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++
> .../reset/raspberrypi,firmware-reset.h | 13 ++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 include/dt-bindings/reset/raspberrypi,firmware-reset.h
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index b48ed875eb8e..23a885af3a28 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -39,6 +39,22 @@ properties:
> - compatible
> - "#clock-cells"
>
> + reset:
> + type: object
> +
> + properties:
> + compatible:
> + const: raspberrypi,firmware-reset
> +
> + "#reset-cells":
> + const: 1
> + description: >
> + The argument is the ID of the firmware reset line to affect.
> +
> + required:
> + - compatible
> + - "#reset-cells"
> +
> additionalProperties: false
>
> required:
> @@ -55,5 +71,10 @@ examples:
> compatible = "raspberrypi,firmware-clocks";
> #clock-cells = <1>;
> };
> +
> + reset: reset {
> + compatible = "raspberrypi,firmware-reset";
> + #reset-cells = <1>;
> + };
> };
> ...
> diff --git a/include/dt-bindings/reset/raspberrypi,firmware-reset.h b/include/dt-bindings/reset/raspberrypi,firmware-reset.h
> new file mode 100644
> index 000000000000..1a4f4c792723
> --- /dev/null
> +++ b/include/dt-bindings/reset/raspberrypi,firmware-reset.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2020 Nicolas Saenz Julienne
> + * Author: Nicolas Saenz Julienne <nsaenzjulienne@...e.com>
> + */
> +
> +#ifndef _DT_BINDINGS_RASPBERRYPI_FIRMWARE_RESET_H
> +#define _DT_BINDINGS_RASPBERRYPI_FIRMWARE_RESET_H
> +
> +#define RASPBERRYPI_FIRMWARE_RESET_ID_USB 0
> +#define RASPBERRYPI_FIRMWARE_RESET_NUM_IDS 1
> +
> +#endif
Are there going to be any more firmware controlled resets in the future?
regards
Philipp
Powered by blists - more mailing lists