linux-kernel - Re: [PATCH v2] Bluetooth: Terminate the link if pairing is cancelled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4F76321E-918F-4A16-B35A-888733D5B75D@holtmann.org>
Date:   Wed, 17 Jun 2020 12:33:47 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Manish Mandlik <mmandlik@...gle.com>
Cc:     Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@...omium.org>,
        Alain Michaud <alainm@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hedberg <johan.hedberg@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Terminate the link if pairing is cancelled

Hi Manish,

> If user decides to cancel the ongoing pairing process (e.g. by clicking
> the cancel button on pairing/passkey window), abort any ongoing pairing
> and then terminate the link if it was created because of the pair
> device action.
> 
> Signed-off-by: Manish Mandlik <mmandlik@...gle.com>
> ---
> 
> Changes in v2:
> - Added code to track if the connection was triggered because of the pair
>  device action and then only terminate the link on pairing cancel.
> 
> include/net/bluetooth/hci_core.h | 14 ++++++++++++--
> net/bluetooth/hci_conn.c         | 11 ++++++++---
> net/bluetooth/l2cap_core.c       |  6 ++++--
> net/bluetooth/mgmt.c             | 22 ++++++++++++++++++----
> 4 files changed, 42 insertions(+), 11 deletions(-)

patch has been added to my local tree. I will send an update with all pending patches in a bit.

Regards

Marcel