linux-kernel - Re: [PATCH 1/3] mips: bmips: add PCI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200617110913.GB9940@alpha.franken.de>
Date:   Wed, 17 Jun 2020 13:09:13 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     bhelgaas@...gle.com, robh+dt@...nel.org, lorenzo.pieralisi@....com,
        p.zabel@...gutronix.de, jiaxun.yang@...goat.com,
        paulburton@...nel.org, info@...ux.net, allison@...utok.net,
        kstewart@...uxfoundation.org, tglx@...utronix.de,
        jonas.gorski@...il.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH 1/3] mips: bmips: add PCI support

On Wed, Jun 17, 2020 at 12:25:54PM +0200, Álvaro Fernández Rojas wrote:
> BMIPS SoCs with PCI: BCM6358, BCM6368.
> BMIPS SoCs with PCIe (gen1): BCM6328, BCM6362, BCM63268.
> BMIPS SoCs with PCIe (gen2): BCM6318.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  arch/mips/Kconfig           |  1 +
>  arch/mips/pci/Makefile      |  1 +
>  arch/mips/pci/fixup-bmips.c | 17 +++++++++++++++++
>  3 files changed, 19 insertions(+)
>  create mode 100644 arch/mips/pci/fixup-bmips.c
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 6fee1a133e9d..357026cb51de 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -230,6 +230,7 @@ config BMIPS_GENERIC
>  	select ARCH_HAS_SYNC_DMA_FOR_CPU_ALL
>  	select ARCH_HAS_PHYS_TO_DMA
>  	select BOOT_RAW
> +	select HAVE_PCI
>  	select NO_EXCEPT_FILL
>  	select USE_OF
>  	select CEVT_R4K

as everything is using DT in your patch, can't you use PCI_DRIVERS_GENERIC
here and drop fixup-bmips ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]