linux-kernel - Re: [PATCH] x86/stackprotector: Pre-initialize canary for secondary CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200617113029.GD10118@zn.tnic>
Date:   Wed, 17 Jun 2020 13:30:29 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Brian Gerst <brgerst@...il.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86/stackprotector: Pre-initialize canary for secondary
 CPUs

On Thu, Jun 04, 2020 at 10:03:59AM -0400, Brian Gerst wrote:
> The idle tasks created for each secondary CPU already have a random stack
> canary generated by fork().  Copy the canary to the percpu variable before
> starting the secondary CPU which removes the need to call
> boot_init_stack_canary().
> 
> Signed-off-by: Brian Gerst <brgerst@...il.com>
> ---
>  arch/x86/include/asm/stackprotector.h | 12 ++++++++++++
>  arch/x86/kernel/smpboot.c             | 12 +-----------
>  arch/x86/xen/smp_pv.c                 |  2 --
>  3 files changed, 13 insertions(+), 13 deletions(-)

arch/x86/kernel/smpboot.c: In function ‘common_cpu_up’:
arch/x86/kernel/smpboot.c:1003:2: error: implicit declaration of function ‘cpu_init_stack_canary’; did you mean ‘boot_init_stack_canary’? [-Werror=implicit-function-declaration]
  cpu_init_stack_canary(cpu, idle);
make[2]: *** [scripts/Makefile.build:281: arch/x86/kernel/smpboot.o] Error 1
make[1]: *** [scripts/Makefile.build:497: arch/x86/kernel] Error 2
make: *** [Makefile:1764: arch/x86] Error 2

.config attached.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

View attachment "12-05-52-randconfig-x86_64-8723.cfg" of type "text/plain" (90988 bytes)