linux-kernel - RE: [PATCH V2 1/9] clk: composite: Export clk_hw_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916CD2DEFC64796E7869EEDF59A0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Wed, 17 Jun 2020 12:31:35 +0000
From:   Anson Huang <anson.huang@....com>
To:     Aisheng Dong <aisheng.dong@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "oleksandr.suvorov@...adex.com" <oleksandr.suvorov@...adex.com>,
        Stefan Agner <stefan.agner@...adex.com>,
        "arnd@...db.de" <arnd@...db.de>, Abel Vesa <abel.vesa@....com>,
        Peng Fan <peng.fan@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "allison@...utok.net" <allison@...utok.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "info@...ux.net" <info@...ux.net>,
        Leonard Crestez <leonard.crestez@....com>,
        Andy Duan <fugang.duan@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite()



> Subject: RE: [PATCH V2 1/9] clk: composite: Export
> clk_hw_register_composite()
> 
> > From: Anson Huang <Anson.Huang@....com>
> > Sent: Tuesday, June 9, 2020 3:32 PM
> >
> > Export clk_hw_register_composite() to support user built as module.
> >
> > ERROR: modpost: "clk_hw_register_composite"
> > [drivers/clk/imx/mxc-clk.ko] undefined!
> > scripts/Makefile.modpost:111: recipe for target 'Module.symvers'
> > failed
> > make[1]: *** [Module.symvers] Error 1
> > make[1]: *** Deleting file 'Module.symvers'
> > Makefile:1384: recipe for target 'modules' failed
> > make: *** [modules] Error 2
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > No change.
> > ---
> >  drivers/clk/clk-composite.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> > index 7376f57..2ddb54f 100644
> > --- a/drivers/clk/clk-composite.c
> > +++ b/drivers/clk/clk-composite.c
> > @@ -328,6 +328,7 @@ struct clk_hw *clk_hw_register_composite(struct
> > device *dev, const char *name,
> >  					   rate_hw, rate_ops, gate_hw,
> >  					   gate_ops, flags);
> >  }
> > +EXPORT_SYMBOL_GPL(clk_hw_register_composite);
> >
> >  struct clk_hw *clk_hw_register_composite_pdata(struct device *dev,
> >  			const char *name,
> 
> I guess you'd better add this one as well.

I did NOT see this is used in upstream i.MX clock driver, from my test, it is not necessary so far.

Anson