lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202006172003.P8R1sD2p%lkp@intel.com>
Date:   Wed, 17 Jun 2020 20:38:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Leo Liu <leo.liu@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>,
        James Zhu <James.Zhu@....com>
Subject: drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:687:6: warning: variable 'ret'
 set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   69119673bd50b176ded34032fadd41530fb5af21
commit: 1b61de45dfaff00b627e47349a019658e39268b9 drm/amdgpu: add initial VCN2.0 support (v2)
date:   12 months ago
config: ia64-randconfig-r012-20200617 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 1b61de45dfaff00b627e47349a019658e39268b9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c: In function 'vcn_v2_0_disable_static_power_gating':
>> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:687:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
687 |  int ret;
|      ^~~
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c: In function 'vcn_v2_0_enable_static_power_gating':
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:736:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
736 |  int ret;
|      ^~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26,
from drivers/gpu/drm/amd/amdgpu/amdgpu.h:53,
from drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:26:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
|                                ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
|                                ^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
|                                ^~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
|                                ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
|                                ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:67:32: warning: 'dc_fixpt_zero' defined but not used [-Wunused-const-variable=]
67 | static const struct fixed31_32 dc_fixpt_zero = { 0 };
|                                ^~~~~~~~~~~~~

vim +/ret +687 drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c

   683	
   684	static void vcn_v2_0_disable_static_power_gating(struct amdgpu_device *adev)
   685	{
   686		uint32_t data = 0;
 > 687		int ret;
   688	
   689		if (adev->pg_flags & AMD_PG_SUPPORT_VCN) {
   690			data = (1 << UVD_PGFSM_CONFIG__UVDM_PWR_CONFIG__SHIFT
   691				| 1 << UVD_PGFSM_CONFIG__UVDU_PWR_CONFIG__SHIFT
   692				| 2 << UVD_PGFSM_CONFIG__UVDF_PWR_CONFIG__SHIFT
   693				| 2 << UVD_PGFSM_CONFIG__UVDC_PWR_CONFIG__SHIFT
   694				| 2 << UVD_PGFSM_CONFIG__UVDB_PWR_CONFIG__SHIFT
   695				| 2 << UVD_PGFSM_CONFIG__UVDIL_PWR_CONFIG__SHIFT
   696				| 2 << UVD_PGFSM_CONFIG__UVDIR_PWR_CONFIG__SHIFT
   697				| 2 << UVD_PGFSM_CONFIG__UVDTD_PWR_CONFIG__SHIFT
   698				| 2 << UVD_PGFSM_CONFIG__UVDTE_PWR_CONFIG__SHIFT
   699				| 2 << UVD_PGFSM_CONFIG__UVDE_PWR_CONFIG__SHIFT
   700				| 2 << UVD_PGFSM_CONFIG__UVDW_PWR_CONFIG__SHIFT);
   701	
   702			WREG32_SOC15(VCN, 0, mmUVD_PGFSM_CONFIG, data);
   703			SOC15_WAIT_ON_RREG(VCN, 0, mmUVD_PGFSM_STATUS,
   704				UVD_PGFSM_STATUS__UVDM_UVDU_PWR_ON, 0xFFFFFF, ret);
   705		} else {
   706			data = (1 << UVD_PGFSM_CONFIG__UVDM_PWR_CONFIG__SHIFT
   707				| 1 << UVD_PGFSM_CONFIG__UVDU_PWR_CONFIG__SHIFT
   708				| 1 << UVD_PGFSM_CONFIG__UVDF_PWR_CONFIG__SHIFT
   709				| 1 << UVD_PGFSM_CONFIG__UVDC_PWR_CONFIG__SHIFT
   710				| 1 << UVD_PGFSM_CONFIG__UVDB_PWR_CONFIG__SHIFT
   711				| 1 << UVD_PGFSM_CONFIG__UVDIL_PWR_CONFIG__SHIFT
   712				| 1 << UVD_PGFSM_CONFIG__UVDIR_PWR_CONFIG__SHIFT
   713				| 1 << UVD_PGFSM_CONFIG__UVDTD_PWR_CONFIG__SHIFT
   714				| 1 << UVD_PGFSM_CONFIG__UVDTE_PWR_CONFIG__SHIFT
   715				| 1 << UVD_PGFSM_CONFIG__UVDE_PWR_CONFIG__SHIFT
   716				| 1 << UVD_PGFSM_CONFIG__UVDW_PWR_CONFIG__SHIFT);
   717			WREG32_SOC15(VCN, 0, mmUVD_PGFSM_CONFIG, data);
   718			SOC15_WAIT_ON_RREG(VCN, 0, mmUVD_PGFSM_STATUS, 0,  0xFFFFFFFF, ret);
   719		}
   720	
   721		/* polling UVD_PGFSM_STATUS to confirm UVDM_PWR_STATUS,
   722		 * UVDU_PWR_STATUS are 0 (power on) */
   723	
   724		data = RREG32_SOC15(VCN, 0, mmUVD_POWER_STATUS);
   725		data &= ~0x103;
   726		if (adev->pg_flags & AMD_PG_SUPPORT_VCN)
   727			data |= UVD_PGFSM_CONFIG__UVDM_UVDU_PWR_ON |
   728				UVD_POWER_STATUS__UVD_PG_EN_MASK;
   729	
   730		WREG32_SOC15(VCN, 0, mmUVD_POWER_STATUS, data);
   731	}
   732	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27664 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ