linux-kernel - Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jun 2020 19:19:04 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     linux-arm-msm@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        linux-remoteproc@...r.kernel.org
Cc:     Sibi Sankar <sibis@...eaurora.org>,
        Vinod Koul <vinod.koul@...aro.org>, agross@...nel.org,
        Ohad Ben Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

+ linux-remoteproc@...r.kernel.org

On Wed, 17 Jun 2020 at 12:27, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
>
> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
>
> Build error:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:
>   In function ‘q6v5_mpss_init_image’:
>  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
>   error: implicit declaration of function ‘kfree’;
>   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
>    772 |   kfree(metadata);
>        |   ^~~~~
>        |   vfree
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> ---
>  drivers/remoteproc/qcom_q6v5_mss.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
>  #include <linux/reset.h>
>  #include <linux/soc/qcom/mdt_loader.h>
>  #include <linux/iopoll.h>
> +#include <linux/slab.h>
>
>  #include "remoteproc_internal.h"
>  #include "qcom_common.h"
> --
> 2.17.1
>