linux-kernel - Re: [PATCH] selinux: fix undefined return of cond_evaluate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEjxPJ5uGV-SjKL7v5J=7YYEBOjyHwK625SX8fzCrbatuB=9hg@mail.gmail.com>
Date:   Wed, 17 Jun 2020 09:58:35 -0400
From:   Stephen Smalley <stephen.smalley.work@...il.com>
To:     trix@...hat.com
Cc:     Paul Moore <paul@...l-moore.com>,
        Eric Paris <eparis@...isplace.org>,
        Ondrej Mosnacek <omosnace@...hat.com>, weiyongjun1@...wei.com,
        SElinux list <selinux@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selinux: fix undefined return of cond_evaluate_expr

On Wed, Jun 17, 2020 at 8:40 AM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> clang static analysis reports an undefined return
>
> security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
>         return s[0];
>         ^~~~~~~~~~~
>
> static int cond_evaluate_expr( ...
> {
>         u32 i;
>         int s[COND_EXPR_MAXDEPTH];
>
>         for (i = 0; i < expr->len; i++)
>           ...
>
>         return s[0];
>
> When expr->len is 0, the loop which sets s[0] never runs.
>
> So return -1 if the loop never runs.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Stephen Smalley <stephen.smalley.work@...il.com>

clang didn't complain about the similar pattern in
security/selinux/ss/services.c:constraint_expr_eval()?