linux-kernel - Re: [PATCH] KVM: VMX: Remove vcpu_vmx's defunct copy of host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALMp9eR-O6ikxYaqi5iYQsVp9KaHDAm_7h4f8FPvssBi2-7Eyw@mail.gmail.com>
Date:   Wed, 17 Jun 2020 09:48:38 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Joerg Roedel <joro@...tes.org>, kvm list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH] KVM: VMX: Remove vcpu_vmx's defunct copy of host_pkru

On Wed, Jun 17, 2020 at 2:19 AM Vitaly Kuznetsov <vkuznets@...hat.com> wrote:
>
> Sean Christopherson <sean.j.christopherson@...el.com> writes:
>
> > Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was
> > moved to common x86 code.
> >
> > No functional change intended.
> >
> > Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c")
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
> > ---
> >  arch/x86/kvm/vmx/vmx.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> > index 8a83b5edc820..639798e4a6ca 100644
> > --- a/arch/x86/kvm/vmx/vmx.h
> > +++ b/arch/x86/kvm/vmx/vmx.h
> > @@ -288,8 +288,6 @@ struct vcpu_vmx {
> >
> >       u64 current_tsc_ratio;
> >
> > -     u32 host_pkru;
> > -
> >       unsigned long host_debugctlmsr;
> >
> >       /*
>
> (Is there a better [automated] way to figure out whether the particular
> field is being used or not than just dropping it and trying to compile
> the whole thing? Leaving #define-s, configs,... aside ...)
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Reviewed-by: Jim Mattson <jmattson@...gle.com>