linux-kernel - Re: [Linux] [PATCH] Kernel selftests: tpm2: upgrade tpm2 tests from python2 to python3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200618075104.GA13935@xpf-desktop.sh.intel.com>
Date:   Thu, 18 Jun 2020 15:51:04 +0800
From:   Pengfei Xu <pengfei.xu@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Shuah Khan <shuah@...nel.org>, Heng Su <heng.su@...el.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kai Svahn <kai.svahn@...el.com>
Subject: Re: [Linux] [PATCH] Kernel selftests: tpm2: upgrade tpm2 tests from
 python2 to python3

Hi Jarkko,
  Thanks for your advice.
  My feedback is as below.

  BR.
  Thanks!

On 2020-06-18 at 10:18:58 +0300, Jarkko Sakkinen wrote:
> On Thu, Jun 18, 2020 at 11:02:45AM +0800, Pengfei Xu wrote:
> > Some Linux OS will never support python2 anymore, so upgrade tpm2 selftests
> > to python3.
> > 
> > Signed-off-by: Pengfei Xu <pengfei.xu@...el.com>
> 
> Linux is a kernel, not a full operating system. Perhaps you mean Linux
> distributions?
> 

  Will remove [Linux], thanks!

> Please capitalize abbrevations correctly (TPM2, not tpm2). Please write
> 'Python 2' instead of python2.
> 

  Will do, thanks!

> With that said the commit message is inaccurate. The root reason for
> moving to Python 3 is that Python 2 is no longer supported by the Python
> upstream project. Nothing to do with Linux or Linux distributions for
> that matter.
> 
  Will do, thanks!

> /Jarkko