linux-kernel - Re: [PATCH] crypto: sa2ul: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9041a082-b1e4-caa0-d93a-5bd4dbc997d6@ti.com>
Date:   Thu, 18 Jun 2020 10:56:21 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Julia Lawall <julia.lawall@...ia.fr>
CC:     Keerthy <j-keerthy@...com>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kbuild-all@...ts.01.org>
Subject: Re: [PATCH] crypto: sa2ul: fix odd_ptr_err.cocci warnings

On 18/06/2020 10:28, Herbert Xu wrote:
> On Fri, Jun 12, 2020 at 11:22:02PM +0200, Julia Lawall wrote:
>> From: kernel test robot <lkp@...el.com>
>>
>> PTR_ERR should normally access the value just tested by IS_ERR
>>
>> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>>
>> Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver")
>> CC: Keerthy <j-keerthy@...com>
>> Signed-off-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
>> ---
>>
>> tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
>> head:   134a1b1f8814115e2dd115b67082321bf9e63cc1
>> commit: 5b8516f3bedb3e1c273e7747b6e4a85c6e47907a [2369/7050] crypto: sa2ul: Add crypto driver
>> :::::: branch date: 3 hours ago
>> :::::: commit date: 5 months ago
>>
>>   sa2ul.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This driver does not exist in the cryptodev tree.

Yeah, this is old codebase which only exist in TI internal tree at the 
moment, the driver posted upstream has seen considerable evolution (and 
is under review atm.)

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki