linux-kernel - Re: [PATCH] soc: xilinx: Fix error code in zynqmp_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e827b05b-c2ed-ef93-80ae-7d8bd0f0ac0d@xilinx.com>
Date:   Thu, 18 Jun 2020 10:07:09 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Michal Simek <michal.simek@...inx.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Tejas Patel <tejas.patel@...inx.com>
Cc:     Rajan Vaja <rajan.vaja@...inx.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jolly Shah <jolly.shah@...inx.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()



On 05. 06. 20 13:07, Michal Simek wrote:
> On 05. 06. 20 13:00, Dan Carpenter wrote:
>> This should be returning PTR_ERR() but it returns IS_ERR() instead.
>>
>> Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>> ---
>>  drivers/soc/xilinx/zynqmp_power.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
>> index 31ff49fcd078b..c556623dae024 100644
>> --- a/drivers/soc/xilinx/zynqmp_power.c
>> +++ b/drivers/soc/xilinx/zynqmp_power.c
>> @@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
>>  		rx_chan = mbox_request_channel_byname(client, "rx");
>>  		if (IS_ERR(rx_chan)) {
>>  			dev_err(&pdev->dev, "Failed to request rx channel\n");
>> -			return IS_ERR(rx_chan);
>> +			return PTR_ERR(rx_chan);
>>  		}
>>  	} else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
>>  		irq = platform_get_irq(pdev, 0);
>>
> 
> Reviewed-by: Michal Simek <michal.simek@...inx.com>

Applied.
M