linux-kernel - Re: [PATCH] staging: rtl8723bs: os_dep: ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200618144009.GT4151@kadam>
Date:   Thu, 18 Jun 2020 17:40:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Shihab Rashed <shihab.rashed97@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: ioctl_cfg80211: fixed code
 styl issues

On Thu, Jun 18, 2020 at 04:10:02PM +0200, Shihab Rashed wrote:
> Fixed two brace coding style issues and one comment style issue found by
> checkpatch.
> 
> Signed-off-by: Shihab Rashed <shihab.rashed97@...il.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 2fb80b6eb51d..3b06b60cdfd1 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -117,15 +117,12 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
>  	struct ieee80211_supported_band *spt_band = NULL;
>  	int n_channels, n_bitrates;
>  
> -	if (band == NL80211_BAND_2GHZ)
> -	{
> +	if (band == NL80211_BAND_2GHZ)	{
                                      ^^
too many spaces.

>  		n_channels = RTW_2G_CHANNELS_NUM;
>  		n_bitrates = RTW_G_RATES_NUM;
> -	}
> -	else
> -	{
> +	} else	{
              ^^
too many spaces.

>  		goto exit;
> -	}
> +		}
                ^
Indented too far.

>  
>  	spt_band = rtw_zmalloc(sizeof(struct ieee80211_supported_band) +
>  			       sizeof(struct ieee80211_channel) * n_channels +


regards,
dan carpenter