[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0b1c1a07b6589e91701a1815400a56b66c5f480d.camel@redhat.com>
Date: Thu, 18 Jun 2020 11:18:25 -0400
From: Lyude Paul <lyude@...hat.com>
To: Aditya Pakki <pakki001@....edu>
Cc: kjlu@....edu, wu000273@....edu, Ben Skeggs <bskeggs@...hat.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Alex Deucher <alexander.deucher@....com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@...el.com>,
Takashi Iwai <tiwai@...e.de>, James Jones <jajones@...dia.com>,
dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/noveau: fix reference count leak in
nv50_disp_atomic_commit
On Sat, 2020-06-13 at 20:29 -0500, Aditya Pakki wrote:
> nv50_disp_atomic_commit() calls calls pm_runtime_get_sync and in turn
> increments the reference count. In case of failure, decrement the
> ref count before returning the error.
>
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index d472942102f5..b4039907f0d6 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2157,8 +2157,10 @@ nv50_disp_atomic_commit(struct drm_device *dev,
> int ret, i;
>
> ret = pm_runtime_get_sync(dev->dev);
> - if (ret < 0 && ret != -EACCES)
> + if (ret < 0 && ret != -EACCES) {
> + pm_runtime_put_autosuspend(dev->dev);
s/noveau/nouveau/ in the commit title, but other than that:
Reviewed-by: Lyude Paul <lyude@...hat.com>
> return ret;
> + }
>
> ret = drm_atomic_helper_setup_commit(state, nonblock);
> if (ret)
Powered by blists - more mailing lists