linux-kernel - Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200618181816.GA2453631@mellanox.com>
Date:   Thu, 18 Jun 2020 15:18:16 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
CC:     <bvanassche@....org>, <dledford@...hat.com>,
        <linux-rdma@...r.kernel.org>, <target-devel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

On Wed, Jun 17, 2020 at 10:08:03PM +0800, Jing Xiangfeng wrote:
> The callers pass the pointer '&req' or 'private_data' to
> srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req().
> 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that
> sdev and req are always valid. So we remove unnecessary WARN_ON.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> ---
>  drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied to for-next, thanks

Jason