linux-kernel - RE: [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR2101MB10472446CC72A17FE2A78920D79B0@DM5PR2101MB1047.namprd21.prod.outlook.com>
Date:   Thu, 18 Jun 2020 18:35:48 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     "Andrea Parri (Microsoft)" <parri.andrea@...il.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the
 vmbus_channel struct

From: Andrea Parri (Microsoft) <parri.andrea@...il.com>  Sent: Wednesday, June 17, 2020 9:47 AM
> 
> The spinlock is (now) *not used to protect test-and-set accesses
> to attributes of the structure or sc_list operations.
> 
> There is, AFAICT, a distinct lack of {WRITE,READ}_ONCE()s in the
> handling of channel->state, but the changes below do not seem to
> make things "worse".  ;-)
> 
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> ---
>  drivers/hv/channel.c      | 6 +-----
>  drivers/hv/channel_mgmt.c | 1 -
>  include/linux/hyperv.h    | 6 ------
>  3 files changed, 1 insertion(+), 12 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>