linux-kernel - Re: [PATCH v3] exfat: remove EXFAT_SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a93d1a1-dc34-f799-240e-843d7f021bbf@gmail.com>
Date:   Fri, 19 Jun 2020 13:22:21 +0900
From:   Tetsuhiro Kohada <kohada.t2@...il.com>
To:     Sungjong Seo <sj1557.seo@...sung.com>
Cc:     kohada.tetsuhiro@...mitsubishielectric.co.jp,
        mori.takahiro@...mitsubishielectric.co.jp,
        motai.hirotaka@...mitsubishielectric.co.jp,
        'Namjae Jeon' <namjae.jeon@...sung.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] exfat: remove EXFAT_SB_DIRTY flag

>> I mentioned rmdir as an example.
>> However, this problem is not only with rmdirs.
>> VOL_DIRTY remains when some functions abort with an error.
>> In original, VOL_DIRTY is not cleared even if performe 'sync'.
>> With this patch, it ensures that VOL_DIRTY will be cleared by 'sync'.
>>
>> Is my description insufficient?
> 
> I understood what you said. However, it is a natural result
> when deleting the related code with EXFAT_SB_DIRTY flag.
> 
> So I thought it would be better to separate it into new problems
> related to VOL_DIRTY-set under not real errors.

I see.
It seems that it is better to consider separately when consistency is corrupted and when it is kept.

>> BTW
>> Even with this patch applied,  VOL_DIRTY remains until synced in the above
>> case.
>> It's not  easy to reproduce as rmdir, but I'll try to fix it in the future.
> 
> I think it's not a problem not to clear VOL_DIRTY under real errors,
> because VOL_DIRTY is just like a hint to note that write was not finished clearly.
> 
> If you mean there are more situation like ENOTEMPTY you mentioned,
> please make new patch to fix them.

Hmm.
VOL_DIRTY is easily cleared by another write operation.
For that purpose, I think MediaFailure is more appropriate.

BR
---
Tetsuhiro Kohada <kohada.t2@...il.com>