linux-kernel - Re: [PATCH] coccinelle: api/kstrdup: fix coccinelle position

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0f221342-cd9c-04d2-da01-f86574d3de34@web.de>
Date:   Fri, 19 Jun 2020 17:26:32 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Denis Efremov <efremov@...ux.com>,
        Coccinelle <cocci@...teme.lip6.fr>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Julia Lawall <julia.lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] coccinelle: api/kstrdup: fix coccinelle position

> There is a typo in rule r2. Position p1 should be attached to kzalloc() call.

I find such a suggestion reasonable for an implementation detail.

I would find an other patch subject clearer.


How do you think about to move the specification “@p1” out of SmPL disjunctions?

Regards,
Markus