linux-kernel - Re: [RFC PATCH ] scsi: remove scsi_sdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc0c3bcf8b77b838316a0c4a53fdddaa476dd0dc.camel@gmail.com>
Date:   Fri, 19 Jun 2020 17:03:47 +0200
From:   Bean Huo <huobean@...il.com>
To:     Bart Van Assche <bvanassche@....org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     beanhuo@...ron.com
Subject: Re: [RFC PATCH ] scsi: remove scsi_sdb_cache

Hi Bart

Thanks.

On Fri, 2020-06-19 at 07:31 -0700, Bart Van Assche wrote:
> On 2020-06-19 06:10, Bean Huo wrote:
> > @@ -2039,7 +2024,6 @@ scsi_mode_select(struct scsi_device *sdev,
> > int pf, int sp, int modepage,
> >  		real_buffer[1] = data->medium_type;
> >  		real_buffer[2] = data->device_specific;
> >  		real_buffer[3] = data->block_descriptor_length;
> > -	
Here delete a blank line since there are multiple blank lines.
> > 	
> >  
> >  		cmd[0] = MODE_SELECT;
> >  		cmd[4] = len;
> > @@ -2227,7 +2211,7 @@ scsi_device_set_state(struct scsi_device
> > *sdev, enum scsi_device_state state)
> >  			goto illegal;
> >  		}
> >  		break;
> > -			
> > +

Here has trailing whitespace, delete it.

> >  	case SDEV_RUNNING:
> >  		switch (oldstate) {
> >  		case SDEV_CREATED:
> 
> If these whitespace changes are left out, feel free to add:
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Bean