lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Jun 2020 08:49:21 +0200 From: John Ogness <john.ogness@...utronix.de> To: kernel test robot <lkp@...el.com> Cc: Petr Mladek <pmladek@...e.com>, kbuild-all@...ts.01.org, Peter Zijlstra <peterz@...radead.org>, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andrea Parri <parri.andrea@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Paul McKenney <paulmck@...nel.org>, kexec@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH] printk: _printk_rb_static_dict can be static On 2020-06-18, kernel test robot <lkp@...el.com> wrote: > Signed-off-by: kernel test robot <lkp@...el.com> > --- > printk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 7642ef634956f..d812ada06735f 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -434,7 +434,7 @@ static u32 log_buf_len = __LOG_BUF_LEN; > */ > #define PRB_AVGBITS 5 /* 32 character average length */ > > -_DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS, > +static _DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS, > PRB_AVGBITS, PRB_AVGBITS, &__log_buf[0]); _DECLARE_PRINTKRB declares multiple variables, so this patch will not work as intended. I would like to declare the variables static but am not sure how best to go about it. In the Linux source I see examples of macros just desclaring the variables static. And I see examples of the macros providing a parameter where the "static" keyword can be specified. Since the ringbuffer was created exclusively to serve printk, I would prefer to just have _DECLARE_PRINTKRB (and DECLARE_PRINTKRB) declare all the variables as static. John Ogness
Powered by blists - more mailing lists