linux-kernel - Re: [PATCHv2 0/2] SBS battery PEC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 18:42:41 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Emil Velikov <emil.velikov@...labora.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCHv2 0/2] SBS battery PEC support

Hi,

On Mon, Jun 08, 2020 at 08:23:05AM +0200, Marek Szyprowski wrote:
> Hi Sebastian,
> 
> On 06.06.2020 01:06, Sebastian Reichel wrote:
> > Second try to enable PEC for SBS battery. Mainline currently
> > has 3 different platforms using sbs-battery with an I2C driver
> > not implementing I2C_M_RECV_LEN:
> >
> >   * i2c-exynos5
> >   * i2c-rk3x
> >   * i2c-tegra
> >
> > On those platforms PEC will be temporarly disabled for SBS
> > functions requesting strings. I considered moving the emulation
> > to I2C core, but it's specific to the SBS battery. The hack
> > only works because the strings are constant.
> 
> Thanks for the update. Works fine on Samsung Exynos-based Chromebooks: 
> Snow, Peach-Pit and Peach-Pi.
> 
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

Thanks, queued.

-- Sebastian

> > Changes since PATCHv1:
> >   * dropped all applied changes
> >   * rebased on top of power-supply's for-next branch
> >   * keep existing string reading method as fallback
> >
> > -- Sebastian
> >
> > Sebastian Reichel (2):
> >    power: supply: sbs-battery: use i2c_smbus_read_block_data()
> >    power: supply: sbs-battery: add PEC support"
> >
> >   drivers/power/supply/sbs-battery.c | 89 +++++++++++++++++++++++++++++-
> >   1 file changed, 87 insertions(+), 2 deletions(-)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)