[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200619173055.GA576888@hirez.programming.kicks-ass.net>
Date: Fri, 19 Jun 2020 19:30:55 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Qais Yousef <qais.yousef@....com>
Cc: Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Patrick Bellasi <patrick.bellasi@...bug.net>,
Chris Redpath <chrid.redpath@....com>,
Lukasz Luba <lukasz.luba@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sched/uclamp: Fix initialization of strut uclamp_rq
On Thu, Jun 18, 2020 at 08:55:24PM +0100, Qais Yousef wrote:
> + for_each_clamp_id(clamp_id) {
> + memset(uc_rq[clamp_id].bucket,
> + 0,
> + sizeof(struct uclamp_bucket)*UCLAMP_BUCKETS);
> +
> + uc_rq[clamp_id].value = uclamp_none(clamp_id);
I think you can replace all that with:
*uc_rq = (struct uclamp_rq){
.value = uclamp_none(clamp_id),
};
it's shorter and is free or weird line-breaks :-)
> + }
Powered by blists - more mailing lists