linux-kernel - Re: [PATCH 11/21] perf/x86/intel/lbr: Support LBR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200619184025.GF576888@hirez.programming.kicks-ass.net>
Date:   Fri, 19 Jun 2020 20:40:25 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     kan.liang@...ux.intel.com
Cc:     mingo@...hat.com, acme@...nel.org, tglx@...utronix.de,
        bp@...en8.de, x86@...nel.org, linux-kernel@...r.kernel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, namhyung@...nel.org, dave.hansen@...el.com,
        yu-cheng.yu@...el.com, bigeasy@...utronix.de, gorcunov@...il.com,
        hpa@...or.com, alexey.budankov@...ux.intel.com, eranian@...gle.com,
        ak@...ux.intel.com, like.xu@...ux.intel.com,
        yao.jin@...ux.intel.com
Subject: Re: [PATCH 11/21] perf/x86/intel/lbr: Support LBR_CTL

On Fri, Jun 19, 2020 at 07:03:59AM -0700, kan.liang@...ux.intel.com wrote:
> -	if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map) {
> +	if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map || x86_pmu.lbr_ctl_map) {

> +	union {
> +		u64		lbr_sel_mask;		   /* LBR_SELECT valid bits */
> +		u64		lbr_ctl_mask;		   /* LBR_CTL valid bits */
> +	};

This makes absolutely no sense. There is hoping the compiler realizes
how stupid that is and fixes it for you, but shees.

Please, just keep the old name.