linux-kernel - Re: [PATCH v2] s390: fix build error for sys_call_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200619192729.GA29309@kernel.org>
Date:   Fri, 19 Jun 2020 16:27:29 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     Xiaoming Ni <nixiaoming@...wei.com>,
        alexander.shishkin@...ux.intel.com, arnd@...db.de,
        borntraeger@...ibm.com, catalin.marinas@....com,
        christian@...uner.io, cyphar@...har.com, dhowells@...hat.com,
        ebiederm@...ssion.com, fenghua.yu@...el.com, geert@...ux-m68k.org,
        gor@...ux.ibm.com, ink@...assic.park.msu.ru, jolsa@...hat.com,
        linux@...linux.org.uk, lkp@...el.com, mark.rutland@....com,
        mattst88@...il.com, minchan@...nel.org, mingo@...hat.com,
        monstr@...str.eu, namhyung@...nel.org, peterz@...radead.org,
        rth@...ddle.net, sargun@...gun.me, sfr@...b.auug.org.au,
        tony.luck@...el.com, will@...nel.org, akpm@...ux-foundation.org,
        alex.huangjianhui@...wei.com, zhongjubin@...wei.com,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v2] s390: fix build error for sys_call_table_emu

Em Fri, Jun 19, 2020 at 04:17:17PM +0200, Heiko Carstens escreveu:
> On Thu, Jun 18, 2020 at 10:14:26PM +0800, Xiaoming Ni wrote:
> > Build error on s390:
> > 	arch/s390/kernel/entry.o: in function `sys_call_table_emu':
> > 	>> (.rodata+0x1288): undefined reference to `__s390_'
> > 
> > In commit ("All arch: remove system call sys_sysctl")
> >  148  common	fdatasync		sys_fdatasync			sys_fdatasync
> > -149  common	_sysctl			sys_sysctl			compat_sys_sysctl
> > +149  common	_sysctl			sys_ni_syscall
> >  150  common	mlock			sys_mlock			sys_mlock
> > 
> > After the patch is integrated, there is a format error in the generated
> > arch/s390/include/generated/asm/syscall_table.h:
> > 	SYSCALL(sys_fdatasync, sys_fdatasync)
> > 	SYSCALL(sys_ni_syscall,) /* cause build error */
> > 	SYSCALL(sys_mlock,sys_mlock)
> > 
> > According to the guidance of Heiko Carstens, use "-" to fill the empty system call
> >  Similarly, modify tools/perf/arch/s390/entry/syscalls/syscall.tbl.
> > 
> > Fixes: ("All arch: remove system call sys_sysctl")
> > Fixes: https://lore.kernel.org/linuxppc-dev/20200616030734.87257-1-nixiaoming@huawei.com/
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>
> > 
> > changes in v2:
> > 	use "-" to fill the empty system call
> > 
> > v1: https://lore.kernel.org/lkml/20200618110320.104013-1-nixiaoming@huawei.com/
> > ---
> >  arch/s390/kernel/syscalls/syscall.tbl           | 2 +-
> >  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>

I get just copies of that file when it gets out of sync, so I suppose
the patch should be just for arch/s390/kernel/syscalls/syscall.tbl and
processed by the s/390 maintainer?

- Arnaldo