linux-kernel - Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 15:26:41 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Simao Gomes Viana <devel@...erboring.dev>,
        linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

On 6/19/20 12:08 PM, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.
> 
> Before:
> drivers/cdrom/cdrom.c:
>     total: 118 errors, 126 warnings, 3794 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 16 warnings, 873 lines checked
> 
> After:
> drivers/cdrom/cdrom.c:
>     total: 0 errors, 38 warnings, 3866 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 3 warnings, 882 lines checked
> 
> Test: scripts/checkpatch.pl --file drivers/cdrom/*.c
> Test: make drivers/cdrom/cdrom.o
> Test: make CONFIG_GDROM=y drivers/cdrom/gdrom.o # partial
> Test: compiles, boots on 5.7.4
> Test: CD ROM works (tested with Audio CD)

Let's please not do this, it's a lot of churn for zero gain.

-- 
Jens Axboe