linux-kernel - Re: [PATCH v1 0/6] console: unify return codes from ->setup() hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 12:47:26 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH v1 0/6] console: unify return codes from ->setup() hook

On Fri, Jun 19, 2020 at 11:39:18AM +0200, Petr Mladek wrote:
> On Thu 2020-06-18 19:47:45, Andy Shevchenko wrote:
> > Some of the console providers treat error code, returned by ->setup() hook,
> > differently. Here is the unification of the behaviour.
> > 
> > The drivers checked by one of the below criteria:
> > 1/ the driver has explicit struct console .setup assignment
> > 2/ the driver has assigned callback to the setup member
> > 
> > All such drivers were read in order to see if there is any problematic return
> > codes, and fixed accordingly which is this series in the result.
> > 
> > Andy Shevchenko (6):
> >   mips: Return proper error code from console ->setup() hook
> >   serial: sunsab: Return proper error code from console ->setup() hook
> >   serial: sunzilog: Return proper error code from console ->setup() hook
> >   tty: hvc: Return proper error code from console ->setup() hook
> >   console: Propagate error code from console ->setup()
> >   console: Fix trivia typo 'change' -> 'chance'
> 
> For the entire patchset:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> 
> I am going to push it the following week via printk tree unless
> anybody complains.

Thanks, Petr, I guess you may also incorporate Sergey's patch he proposed. Sergey, are you going to submit it officially?

-- 
With Best Regards,
Andy Shevchenko