linux-kernel - Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jun 2020 12:50:49 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Richard Dodd <richard.o.dodd@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Jonathan Cox <jonathan@...ox.net>,
        Thiébaud Weksteen <tweek@...gle.com>,
        Nishad Kamdar <nishadkamdar@...il.com>
Subject: Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE

On Thu, 2020-06-18 at 11:42 +0200, Greg Kroah-Hartman wrote:
> The USB core has a quirk flag to ignore specific endpoints, so rename
> it
> to be more obvious what this quirk does.
> 
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Richard Dodd <richard.o.dodd@...il.com>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Jonathan Cox <jonathan@...ox.net>
> Cc: Bastien Nocera <hadess@...ess.net>
> Cc: "Thiébaud Weksteen" <tweek@...gle.com>
> Cc: Nishad Kamdar <nishadkamdar@...il.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

If the driver API change below is agreeable, you can add my:
Reviewed-by: Bastien Nocera <hadess@...ess.net>

Good job.

<snip>
> diff --git a/include/linux/usb/quirks.h b/include/linux/usb/quirks.h
> index 22c1f579afe3..5e4c497f54d6 100644
> --- a/include/linux/usb/quirks.h
> +++ b/include/linux/usb/quirks.h
> @@ -69,7 +69,7 @@
>  /* Hub needs extra delay after resetting its port. */
>  #define USB_QUIRK_HUB_SLOW_RESET		BIT(14)
>  
> -/* device has blacklisted endpoints */
> -#define USB_QUIRK_ENDPOINT_BLACKLIST		BIT(15)
> +/* device has endpoints that should be ignored */
> +#define USB_QUIRK_ENDPOINT_IGNORE		BIT(15)
>  
>  #endif /* __LINUX_USB_QUIRKS_H */