linux-kernel - Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d03c88ea-200d-54ab-d7f3-f3e5b7a0a9dd@redhat.com>
Date:   Fri, 19 Jun 2020 13:49:10 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Weilong Chen <chenweilong@...wei.com>, mst@...hat.com,
        jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        lizefan@...wei.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio-mem: Fix build error due to improper use 'select'

On 19.06.20 10:03, Weilong Chen wrote:
> As noted in:
> https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
> "select should be used with care. select will force a symbol to a
> value without visiting the dependencies."

Right, rings a bell.

> Config VIRTIO_MEM should not select CONTIG_ALLOC directly.
> Otherwise it will cause an error:
> https://bugzilla.kernel.org/show_bug.cgi?id=208245

Thanks!

Acked-by: David Hildenbrand <david@...hat.com>

> 
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> ---
>  drivers/virtio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 5809e5f5b157..5c92e4a50882 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -85,7 +85,7 @@ config VIRTIO_MEM
>  	depends on VIRTIO
>  	depends on MEMORY_HOTPLUG_SPARSE
>  	depends on MEMORY_HOTREMOVE
> -	select CONTIG_ALLOC
> +	depends on CONTIG_ALLOC
>  	help
>  	 This driver provides access to virtio-mem paravirtualized memory
>  	 devices, allowing to hotplug and hotunplug memory.
> 


-- 
Thanks,

David / dhildenb