linux-kernel - Re: [PATCH] soc: imx-scu: Support module build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3AnZ3LpYmeerHQUWNWE4iT6Zn=QAiuJb2Crz02Pc4kAg@mail.gmail.com>
Date:   Fri, 19 Jun 2020 14:09:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Anson Huang <anson.huang@....com>
Cc:     Aisheng Dong <aisheng.dong@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Peng Fan <peng.fan@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        Daniel Baluta <daniel.baluta@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] soc: imx-scu: Support module build

On Fri, Jun 19, 2020 at 9:40 AM Anson Huang <anson.huang@....com> wrote:
> > Subject: RE: [PATCH] soc: imx-scu: Support module build
> >
> > > From: Arnd Bergmann <arnd@...db.de> Sent: Thursday, June 18, 2020 3:21 PM
> > > I see that there is indeed a driver for the device node in
> > > drivers/firmware/imx/imx-scu.c, the only reason for this module using
> > > device_initcall() with a manual
> > > platform_device_register_simple() seems to be that we cannot have two
> > > platform drivers bind to the same device node.
> > >
> > > I think a cleaner way to handle this would be to just move the entire
> > > soc driver into the firmware driver and then remove the duplication.
> > >
> >
> > Yes, sounds like a good idea to me.
>
> So the idea is to remove this driver and implement the soc id/revision/serial_number etc.
> in drivers/firmware/imx/imx-scu.c, right?

Yes, I think you can basically merge imx_scu_soc_probe() into imx_scu_probe()
or call it from there, with only a few changes.

      Arnd