linux-kernel - Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200619122429.GA1037991@kroah.com>
Date:   Fri, 19 Jun 2020 14:24:29 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Hans de Goede <hdegoede@...hat.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Richard Dodd <richard.o.dodd@...il.com>,
        Jonathan Cox <jonathan@...ox.net>,
        Thiébaud Weksteen <tweek@...gle.com>,
        Nishad Kamdar <nishadkamdar@...il.com>
Subject: Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE

On Fri, Jun 19, 2020 at 01:08:53PM +0200, Bastien Nocera wrote:
> On Fri, 2020-06-19 at 12:53 +0200, Hans de Goede wrote:
> > A note for future reference, not sure what you mean with driver
> > 
> > API here. If you mean the in kernel API, the kernel rules are
> > 
> > that we are always free to change that (Linux does not have a
> > 
> > stable driver API).
> > 
> > 
> > 
> > So if a header does not sit under include/uapi (indicating that
> > 
> > it is an userspace API) then a change like this is fine.
> 
> I meant the internal driver API, which might break out-of-tree drivers.

There is no such thing.  Well, there might be, but we don't care and
have to act as if there are no such thing otherwise we would never be
able to change anything :)

> I know that this API is fluid, and that there are no stability
> guarantees, but I'd still expect at least a note in the commit message
> to that effect.

Why?  Who cares?  Anyone who lives outside of the kernel already knows
they have to dig in the kernel if their code breaks, that's the cost of
living outside of the kernel.

thanks,

greg k-h