linux-kernel - Re: [PATCH] Revert "Makefile: install modules.builtin even if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a34e0d3-0035-7775-bd31-7dbdae9c968d@roeck-us.net>
Date:   Fri, 19 Jun 2020 06:16:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christoph Hellwig <hch@...radead.org>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Jonas Karlman <jonas@...boo.se>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "Makefile: install modules.builtin even if
 CONFIG_MODULES=n"

On 6/19/20 12:47 AM, Christoph Hellwig wrote:
> On Fri, Jun 19, 2020 at 01:48:23PM +0900, Masahiro Yamada wrote:
>> This reverts commit e0b250b57dcf403529081e5898a9de717f96b76b.
>>
>> Now that "make install" copies modules.builtin to $(INSTALL_MOD_PATH),
>> it breaks systems that do not set INSTALL_MOD_PATH for "make install".
>>
>> While modules.builtin is useful for CONFIG_MODULES=n, this way gives
>> unexpected impact to existing systems. Maybe "make modules_install"
>> can install modules.builtin irrespective of CONFIG_MODULES as Jonas
>> originally suggested. Anyway, this commit should be reverted ASAP.
> 
> What is the "unexpected impact?  This commit log needs to explain
> that.
> 

$ make INSTALL_PATH=/tmp/destdir install
mkdir: cannot create directory ‘/lib/modules/5.8.0-rc1+/’: Permission denied
Makefile:1342: recipe for target '_builtin_inst_' failed
make: *** [_builtin_inst_] Error 1

Guenter