linux-kernel - Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed fields in initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006190948.KXS7uxwP%lkp@intel.com>
Date:   Fri, 19 Jun 2020 09:26:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Niklas Cassel <niklas.cassel@....com>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Niklas Cassel <niklas.cassel@....com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] nvme: remove workarounds for gcc bug wrt unnamed
 fields in initializers

Hi Niklas,

I love your patch! Yet something to improve:

[auto build test ERROR on block/for-next]
[also build test ERROR on linus/master v5.8-rc1 next-20200618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Niklas-Cassel/nvme-remove-workarounds-for-gcc-bug-wrt-unnamed-fields-in-initializers/20200618-223525
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/nvme/host/rdma.c:1814:20: error: use of undeclared identifier 'priv'
                   .private_data = &priv,
                                    ^
   drivers/nvme/host/rdma.c:1815:30: error: use of undeclared identifier 'priv'
                   .private_data_len = sizeof(priv),
                                              ^
   2 errors generated.

vim +/priv +1814 drivers/nvme/host/rdma.c

  1803	
  1804	static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)
  1805	{
  1806		struct nvme_rdma_ctrl *ctrl = queue->ctrl;
  1807		struct rdma_conn_param param = {
  1808			.qp_num = queue->qp->qp_num,
  1809			.flow_control = 1,
  1810			.responder_resources = queue->device->dev->attrs.max_qp_rd_atom,
  1811			/* maximum retry count */
  1812			.retry_count = 7,
  1813			.rnr_retry_count = 7,
> 1814			.private_data = &priv,
  1815			.private_data_len = sizeof(priv),
  1816		};
  1817		struct nvme_rdma_cm_req priv = {
  1818			.recfmt = cpu_to_le16(NVME_RDMA_CM_FMT_1_0),
  1819			.qid = cpu_to_le16(nvme_rdma_queue_idx(queue)),
  1820		};
  1821		int ret;
  1822	
  1823		/*
  1824		 * set the admin queue depth to the minimum size
  1825		 * specified by the Fabrics standard.
  1826		 */
  1827		if (priv.qid == 0) {
  1828			priv.hrqsize = cpu_to_le16(NVME_AQ_DEPTH);
  1829			priv.hsqsize = cpu_to_le16(NVME_AQ_DEPTH - 1);
  1830		} else {
  1831			/*
  1832			 * current interpretation of the fabrics spec
  1833			 * is at minimum you make hrqsize sqsize+1, or a
  1834			 * 1's based representation of sqsize.
  1835			 */
  1836			priv.hrqsize = cpu_to_le16(queue->queue_size);
  1837			priv.hsqsize = cpu_to_le16(queue->ctrl->ctrl.sqsize);
  1838		}
  1839	
  1840		ret = rdma_connect(queue->cm_id, &param);
  1841		if (ret) {
  1842			dev_err(ctrl->ctrl.device,
  1843				"rdma_connect failed (%d).\n", ret);
  1844			goto out_destroy_queue_ib;
  1845		}
  1846	
  1847		return 0;
  1848	
  1849	out_destroy_queue_ib:
  1850		nvme_rdma_destroy_queue_ib(queue);
  1851		return ret;
  1852	}
  1853	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (75296 bytes)