linux-kernel - RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <231786897.01592525881606.JavaMail.epsvc@epcpadp2>
Date:   Fri, 19 Jun 2020 09:12:20 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Avri Altman <Avri.Altman@....com>,
        Daejun Park <daejun7.park@...sung.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Adel Choi <adel.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read

> +static void ufshpb_run_active_subregion_list(struct ufshpb_lu *hpb)
> > +{
> > +       struct ufshpb_region *rgn;
> > +       struct ufshpb_subregion *srgn;
> > +       struct ufshpb_map_ctx *mctx;
> mctx  doesn't really do anything here

OK, I will delete it.

> > +       unsigned long flags;
> > +       int ret = 0;
> > +
> > +       spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +       while ((srgn = list_first_entry_or_null(&hpb->lh_act_srgn,
> > +                                               struct ufshpb_subregion,
> > +                                               list_act_srgn))) {
> > +               list_del_init(&srgn->list_act_srgn);
> > +               spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
> > +
> > +               rgn = hpb->rgn_tbl + srgn->rgn_idx;
> > +               mctx = NULL;
> > +               ret = ufshpb_add_region(hpb, rgn);
> > +               if (ret)
> > +                       break;
> > +
> > +               ret = ufshpb_issue_map_req(hpb, rgn, srgn);
> > +               if (ret) {
> > +                       dev_notice(&hpb->hpb_lu_dev,
> > +                           "issue map_req failed. ret %d, region %d - %d\n",
> > +                           ret, rgn->rgn_idx, srgn->srgn_idx);
> > +                       break;
> > +               }
> > +               spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +       }
> > +
> > +       if (ret) {
> > +               dev_notice(&hpb->hpb_lu_dev, "region %d - %d, will retry\n",
> > +                          rgn->rgn_idx, srgn->srgn_idx);
> > +               spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +               ufshpb_add_active_list(hpb, rgn, srgn);
> > +       }
> > +       spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
> > +}
> 
>