lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jun 2020 19:41:48 -0700 (PDT) From: David Miller <davem@...emloft.net> To: andrew@...n.ch Cc: f.fainelli@...il.com, netdev@...r.kernel.org, vivien.didelot@...il.com, kuba@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count From: Andrew Lunn <andrew@...n.ch> Date: Thu, 18 Jun 2020 14:56:40 +0200 > That if_find_node_by_name() does a put is not very intuitive. > Maybe document that as well in the kerneldocs? > > Reviewed-by: Andrew Lunn <andrew@...n.ch> I've been complaining about the non-intuitiveness of the various OF interfaces for a long time. They transfer reference counts across objects, and that makes the logic hard to audit. The iterators are the worst.
Powered by blists - more mailing lists