linux-kernel - Re: [PATCH v1 1/3] iio:adc:ltc2471: add match table for existing devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200620162031.5e9330d8@archlinux>
Date:   Sat, 20 Jun 2020 16:20:31 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Darius Berghe <darius.berghe@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/3] iio:adc:ltc2471: add match table for existing
 devices

On Wed, 17 Jun 2020 16:35:21 +0300
Darius Berghe <darius.berghe@...log.com> wrote:

> OF style match table is the proper way of matching device tree nodes
> with drivers and such table was missing, this commit adds it.
> 
> Signed-off-by: Darius Berghe <darius.berghe@...log.com>

Hi Darius

A few minor things inline.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ltc2471.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/adc/ltc2471.c b/drivers/iio/adc/ltc2471.c
> index 55fab612843a..0e5cdb43a943 100644
> --- a/drivers/iio/adc/ltc2471.c
> +++ b/drivers/iio/adc/ltc2471.c
> @@ -143,9 +143,17 @@ static const struct i2c_device_id ltc2471_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, ltc2471_i2c_id);
>  
> +static const struct of_device_id ltc2471_of_match[] = {

Should include mod_device_table.h as we are using of_device_id
which is defined in that header.

> +	{ .compatible = "adi,ltc2471" },
> +	{ .compatible = "adi,ltc2473" },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, ltc2471_of_match);
> +
>  static struct i2c_driver ltc2471_i2c_driver = {
>  	.driver = {
>  		.name = "ltc2471",
> +		.of_match_table = of_match_ptr(ltc2471_of_match)

Drop the of_match_ptr protection. That prevents the use of
this binding with ACPI (via the magic of PRP0001 which allows
you to use DT bindings in an ACPI DSDT). 

We are slowly working our way through all the drivers removing the
use of this macro (and converting to generic binding handling
where relevant). It'll take a while yet though before there
are no instances of this to copy!


>  	},
>  	.probe    = ltc2471_i2c_probe,
>  	.id_table = ltc2471_i2c_id,