linux-kernel - Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200619230933.52058bd7@cinderbox>
Date:   Fri, 19 Jun 2020 23:09:33 -0400
From:   Jeffrey Lin <jeffrey@...rse.nl>
To:     Pali Rohár <pali@...nel.org>
Cc:     jdelvare@...e.com, linux@...ck-us.net, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control
 whitelist

On Fri, 19 Jun 2020 14:18:21 +0200
Pali Rohár <pali@...nel.org> wrote:

>On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote:
>> This allows manual PWM control without the BIOS fighting back on Dell
>> Latitude 5480.
>> 
>> Signed-off-by: Jeffrey Lin <jeffrey@...rse.nl>  
>
>If it is working fine on your machine, you can add my:

Yes, the below patch works on my machine.  dmesg reports "dell_smm_hwmon:
enabling support for setting automatic/manual fan control" and writing 1 to
/sys/class/hwmon/hwmon4/pwm1_enable allows pwmconfig/fancontrol full control.

>
>Acked-by: Pali Rohár <pali@...nel.org>
>
>> ---
>>  drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 16be012a95ed..ec448f5f2dc3 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1187,6 +1187,14 @@ static struct dmi_system_id
>> i8k_whitelist_fan_control[] __initdata = { },
>>  		.driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], },
>> +	{
>> +		.ident = "Dell Latitude 5480",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
>> +		},
>> +		.driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> +	},
>>  	{
>>  		.ident = "Dell Latitude E6440",
>>  		.matches = {
>> -- 
>> 2.27.0
>>   


Content of type "application/pgp-signature" skipped