linux-kernel - Re: [PATCH 1/3] crypto: ccree: fix resource leak on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3a4ddd15-e8a9-33fb-007a-d50137c378a6@web.de>
Date:   Sun, 21 Jun 2020 11:28:00 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Gilad Ben-Yossef <gilad@...yossef.com>,
        linux-crypto@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ofir Drang <ofir.drang@....com>
Subject: Re: [PATCH 1/3] crypto: ccree: fix resource leak on error path

> Fix a small resource leak on the error path of cipher processing.

Would you like to add the tag “Fixes” to the commit message?


…
> +++ b/drivers/crypto/ccree/cc_cipher.c
…
> @@ -190,21 +198,19 @@  static int cc_cipher_init(struct crypto_tfm *tfm)
…
> -	return rc;
> +out_key:
> +	kfree(ctx_p->user.key);
> +out_shash:
> +	crypto_free_shash(ctx_p->shash_tfm);
…

How do you think about to replace the prefix “out” by “free” in these labels?

Regards,
Markus