linux-kernel - Re: [PATCH v3 03/14] crypto: sun8i-ss: support hash algorithms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006220551.SPEvim2w%lkp@intel.com>
Date:   Mon, 22 Jun 2020 05:06:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Corentin Labbe <clabbe@...libre.com>, davem@...emloft.net,
        herbert@...dor.apana.org.au, mripard@...nel.org, wens@...e.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
        Corentin Labbe <clabbe@...libre.com>
Subject: Re: [PATCH v3 03/14] crypto: sun8i-ss: support hash algorithms

Hi Corentin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on sunxi/sunxi/for-next]
[also build test WARNING on cryptodev/master crypto/master v5.8-rc1 next-20200621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Corentin-Labbe/crypto-allwinner-add-xRNG-and-hashes/20200622-033401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ef455a55bcf2cfea04a99c361b182ad18b7f03f1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c:175:5: warning: no previous prototype for function 'sun8i_ss_hash_digest_fb' [-Wmissing-prototypes]
int sun8i_ss_hash_digest_fb(struct ahash_request *areq)
^
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c:175:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sun8i_ss_hash_digest_fb(struct ahash_request *areq)
^
static
1 warning generated.

vim +/sun8i_ss_hash_digest_fb +175 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c

   174	
 > 175	int sun8i_ss_hash_digest_fb(struct ahash_request *areq)
   176	{
   177		struct sun8i_ss_hash_reqctx *rctx = ahash_request_ctx(areq);
   178		struct crypto_ahash *tfm = crypto_ahash_reqtfm(areq);
   179		struct sun8i_ss_hash_tfm_ctx *tfmctx = crypto_ahash_ctx(tfm);
   180	#ifdef CONFIG_CRYPTO_DEV_SUN8I_SS_DEBUG
   181		struct ahash_alg *alg = __crypto_ahash_alg(tfm->base.__crt_alg);
   182		struct sun8i_ss_alg_template *algt;
   183	#endif
   184	
   185		ahash_request_set_tfm(&rctx->fallback_req, tfmctx->fallback_tfm);
   186		rctx->fallback_req.base.flags = areq->base.flags &
   187						CRYPTO_TFM_REQ_MAY_SLEEP;
   188	
   189		rctx->fallback_req.nbytes = areq->nbytes;
   190		rctx->fallback_req.src = areq->src;
   191		rctx->fallback_req.result = areq->result;
   192	#ifdef CONFIG_CRYPTO_DEV_SUN8I_SS_DEBUG
   193		algt = container_of(alg, struct sun8i_ss_alg_template, alg.hash);
   194		algt->stat_fb++;
   195	#endif
   196	
   197		return crypto_ahash_digest(&rctx->fallback_req);
   198	}
   199	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (74027 bytes)