linux-kernel - RE: [PATCH v1 1/3] scsi: ufs: add write booster feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR04MB46402FD7981F9FCA2111AB37FC960@SN6PR04MB4640.namprd04.prod.outlook.com>
Date:   Sun, 21 Jun 2020 07:40:27 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Rob Clark <robdclark@...il.com>,
        Asutosh Das <asutoshd@...eaurora.org>
CC:     "cang@...eaurora.org" <cang@...eaurora.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Bean Huo <beanhuo@...ron.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Colin Ian King <colin.king@...onical.com>,
        Bart Van Assche <bvanassche@....org>,
        open list <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: RE: [PATCH v1 1/3] scsi: ufs: add write booster feature support

 
> 
> On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das <asutoshd@...eaurora.org>
> wrote:
> >
> > The write performance of TLC NAND is considerably
> > lower than SLC NAND. Using SLC NAND as a WriteBooster
> > Buffer enables the write request to be processed with
> > lower latency and improves the overall write performance.
> >
> > Adds support for shared-buffer mode WriteBooster.
> >
> > WriteBooster enable: SW enables it when clocks are
> > scaled up, thus it's enabled only in high load conditions.
> >
> > WriteBooster disable: SW will disable the feature,
> > when clocks are scaled down. Thus writes would go as normal
> > writes.
> 
> btw, in v5.8-rc1 (plus handful of remaining patches for lenovo c630
> laptop (sdm850)), I'm seeing a lot of:
> 
>   ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for
> idn 14 failed, err = 253
>   ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for
> idn 14 failed, err = 253
>   ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag_retry: query attribute,
> opcode 6, idn 14, failed with error 253 after 3 retires
>   ufshcd-qcom 1d84000.ufshc: ufshcd_wb_ctrl write booster enable failed 253
> 
> and at least subjectively, compiling mesa seems slower, which seems
> like it might be related?
This looks like a device issue to be taken with the flash vendor:
The device reports that it supports wd, but returns inalid idn for flag 0xe...

Thanks,
Avri