linux-kernel - Re: [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622182230.GC405672@lunn.ch>
Date:   Mon, 22 Jun 2020 20:22:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     yunaixin03610@....com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-kernel@...r.kernel.org, wuguanping@...wei.com,
        wangqindong@...wei.com
Subject: Re: [PATCH 4/5] Huawei BMA: Adding Huawei BMA driver: cdev_veth_drv

On Tue, Jun 23, 2020 at 12:03:10AM +0800, yunaixin03610@....com wrote:
> From: yunaixin <yunaixin03610@....com>
> 
> The BMA software is a system management software offered by Huawei. It supports the status monitoring, performance monitoring, and event monitoring of various components, including server CPUs, memory, hard disks, NICs, IB cards, PCIe cards, RAID controller cards, and optical modules.
> 
> This cdev_veth_drv driver is one of the communication drivers used by BMA software. It depends on the host_edma_drv driver. It will create a char device once loaded, offering interfaces (open, close, read, write and poll) to BMA to send/receive RESTful messages between BMC software. When the message is longer than 1KB, it will be cut into packets of 1KB. The other side, BMC's cdev_veth driver, will assemble these packets back into original mesages.

Again, you never replied to my questions. In general, a char dev
interface to 'firmware' is not allowed. So i suggest you drop this
patch.

	Andrew