linux-kernel - Re: [PATCH] cpu/speculation: Add prototype for cpu_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200622190814.GA13232@mtg-dev.jf.intel.com>
Date:   Mon, 22 Jun 2020 12:08:14 -0700
From:   mark gross <mgross@...ux.intel.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Borislav Petkov <bp@...e.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH] cpu/speculation: Add prototype for cpu_show_srbds

ack
Reviewed-by: mark gross <mgross@...ux.intel.com>

--mark


On Wed, Jun 17, 2020 at 07:14:10AM -0700, Guenter Roeck wrote:
> 0-day is not happy that there is no prototype for cpu_show_srbds().
> 
> drivers/base/cpu.c:565:16: error:
> 		no previous prototype for 'cpu_show_srbds'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 7e5b3c267d25 ("x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  include/linux/cpu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/cpu.h b/include/linux/cpu.h
> index 52692587f7fe..8aa84c052fdf 100644
> --- a/include/linux/cpu.h
> +++ b/include/linux/cpu.h
> @@ -64,6 +64,7 @@ extern ssize_t cpu_show_tsx_async_abort(struct device *dev,
>  					char *buf);
>  extern ssize_t cpu_show_itlb_multihit(struct device *dev,
>  				      struct device_attribute *attr, char *buf);
> +extern ssize_t cpu_show_srbds(struct device *dev, struct device_attribute *attr, char *buf);
>  
>  extern __printf(4, 5)
>  struct device *cpu_device_create(struct device *parent, void *drvdata,
> -- 
> 2.17.1
>