linux-kernel - Re: [PATCH resend] net: cxgb4: fix return error value in t4_prep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200622134444.78f3fd74@kicinski-fedora-PC1C0HJN>
Date:   Mon, 22 Jun 2020 13:44:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Li Heng <liheng40@...wei.com>
Cc:     <vishal@...lsio.com>, <davem@...emloft.net>,
        <hariprasad@...lsio.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend] net: cxgb4: fix return error value in t4_prep_fw

On Sat, 20 Jun 2020 10:49:21 +0800 Li Heng wrote:
> t4_prep_fw goto bye tag with positive return value when something
> bad happened and which can not free resource in adap_init0.
> so fix it to return negative value.
> 
> Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Li Heng <liheng40@...wei.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

I don't remember signing off on this..